netdev - Re: [PATCH] NFSD: remove NLM_F_MULTI flag in nfsd_genl_rpc_status_compose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZR6tGx/vqRURMmxo@tissot.1015granger.net>
Date: Thu, 5 Oct 2023 08:33:31 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: linux-nfs@...r.kernel.org, lorenzo.bianconi@...hat.com, jlayton@...nel.org,
        neilb@...e.de, netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH] NFSD: remove NLM_F_MULTI flag in
 nfsd_genl_rpc_status_compose_msg

On Thu, Oct 05, 2023 at 11:38:17AM +0200, Lorenzo Bianconi wrote:
> Get rid of unnecessary NLM_F_MULTI flag in nfsd_genl_rpc_status_compose_msg
> routine
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
>  fs/nfsd/nfsctl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Squashed. Thanks!


> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index b71744e355a8..739ed5bf71cd 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1527,8 +1527,7 @@ static int nfsd_genl_rpc_status_compose_msg(struct sk_buff *skb,
>  	u32 i;
>  
>  	hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq,
> -			  &nfsd_nl_family, NLM_F_MULTI,
> -			  NFSD_CMD_RPC_STATUS_GET);
> +			  &nfsd_nl_family, 0, NFSD_CMD_RPC_STATUS_GET);
>  	if (!hdr)
>  		return -ENOBUFS;
>  
> -- 
> 2.41.0
> 

-- 
Chuck Lever