netdev - Re: [PATCH v3] net: phy: broadcom: add support for BCM5221 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6845daf40e0bd79c9768e83928b308e84459c010.camel@redhat.com>
Date: Thu, 05 Oct 2023 12:34:00 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Giulio Benetti <giulio.benetti@...ettiengineering.com>, 
	linux-kernel@...r.kernel.org
Cc: Florian Fainelli <f.fainelli@...il.com>, Broadcom internal kernel review
 list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
 netdev@...r.kernel.org, Giulio Benetti
 <giulio.benetti+tekvox@...ettiengineering.com>, Jim Reinhart
 <jimr@...vox.com>,  James Autry <jautry@...vox.com>, Matthew Maron
 <matthewm@...vox.com>
Subject: Re: [PATCH v3] net: phy: broadcom: add support for BCM5221 phy

On Thu, 2023-09-28 at 20:59 +0200, Giulio Benetti wrote:
> From: Giulio Benetti <giulio.benetti+tekvox@...ettiengineering.com>
> 
> This patch adds the BCM5221 PHY support by reusing brcm_fet_*()
> callbacks and adding quirks for BCM5221 when needed.
> 
> Cc: Jim Reinhart <jimr@...vox.com>
> Cc: James Autry <jautry@...vox.com>
> Cc: Matthew Maron <matthewm@...vox.com>
> Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@...ettiengineering.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@...ettiengineering.com>
> ---
> V1->V2:
> Suggested by Andrew Lunn:
> * handle mdix_ctrl adding bcm5221_config_aneg() and bcm5221_read_status()
> * reorder PHY_ID_BCM5241 in broadcom_tbl[]
> Suggested by Russell King:
> * add comment on phy_read(..., MII_BRCM_FET_INTREG)
> * lock mdio bus when in shadow mode
> Suggested by Florian Fainelli:
> * reuse brcm_fet_*() callbacks checking for phy_id == PHY_ID_BCM5221
> 
> V2->V3:
> * rebase on master branch

LGTM, but waiting an extra bit for explicit ack from Florian.

Cheers,

Paolo