netdev - Re: [EXTERNAL] Re: [PATCH net-next v3] net: ti: icssg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fba767da-ae4d-9fb8-b637-955363a57540@ti.com>
Date: Thu, 5 Oct 2023 11:10:00 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Andrew Lunn <andrew@...n.ch>, Roger Quadros <rogerq@...nel.org>,
        Vignesh
 Raghavendra <vigneshr@...com>,
        Richard Cochran <richardcochran@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
        "David
 S. Miller" <davem@...emloft.net>, <vladimir.oltean@....com>,
        Simon Horman
	<horms@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <srk@...com>, <r-gunasekaran@...com>,
        <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        Roger Quadros <rogerq@...com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [EXTERNAL] Re: [PATCH net-next v3] net: ti: icssg_prueth: add
 TAPRIO offload support

On 05/10/23 02:28, Jakub Kicinski wrote:
> On Thu, 28 Sep 2023 16:00:00 +0530 MD Danish Anwar wrote:
>> +/**
>> + * Config state machine variables. See IEEE Std 802.1Q-2018 8.6.8.4
>> + */
> 
> Please use correct kdoc format with all members documented or not use
> the /** marker.
> 

Sure. I will update the documentation with correct kdoc format.

>> +struct tas_config_list {
>> +	/* New list is copied at this time */
>> +	u64 config_change_time;
>> +	/* config change error counter, incremented if
>> +	 * admin->BaseTime < current time and TAS_enabled is true
>> +	 */
>> +	u32 config_change_error_counter;
>> +	/* True if list update is pending */
>> +	u8 config_pending;
>> +	/* Set to true when application trigger updating of admin list
>> +	 * to active list, cleared when configChangeTime is updated
>> +	 */
>> +	u8 config_change;
>> +};

-- 
Thanks and Regards,
Danish