netdev - RE: [EXT] Re: [Linux-stm32] [PATCH net] net: stmmac: dwmac-imx: request high frequency mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 5 Oct 2023 14:56:57 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shawn Guo
	<shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>
CC: "imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Jose Abreu <joabreu@...opsys.com>, dl-linux-imx
	<linux-imx@....com>, Pengutronix Kernel Team <kernel@...gutronix.de>, Mario
 Ignacio Castaneda Lopez <mario.ignacio.castaneda.lopez@....com>, Fabio
 Estevam <festevam@...il.com>, "linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [Linux-stm32] [PATCH net] net: stmmac: dwmac-imx:
 request high frequency mode



> -----Original Message-----
> From: Ahmad Fatoum <a.fatoum@...gutronix.de>
> Sent: Thursday, October 5, 2023 1:28 AM
> To: Shenwei Wang <shenwei.wang@....com>; David S. Miller
> >                       clk_disable_unprepare(dwmac->clk_mem);
> >                       return ret;
> >               }
> > +             request_bus_freq(BUS_FREQ_HIGH);
>
> I don't find request_bus_freq in linux-next (next-20231005). AFAIK, it was only
> ever suggested as RFC and never went beyond that as a reimplmeentation on
> top of devfreq was requested instead of the i.MX-specific API used in the vendor
> fork.
>
> Did you observe this performance pregression with mainline?

My apologies. I did not realize I was working on a wrong working tree. The busfreq-imx
driver hasn't yet gotten upstreamed.

Please ignore this patch.

Regards,
Shenwei

>
> Cheers,
> Ahmad
>
>
> >       } else {
> > +             release_bus_freq(BUS_FREQ_HIGH);
> >               clk_disable_unprepare(dwmac->clk_tx);
> >               clk_disable_unprepare(dwmac->clk_mem);
> >       }
>
> --
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       |
> http://www.pen/
> gutronix.de%2F&data=05%7C01%7Cshenwei.wang%40nxp.com%7Cbab522390
> 5f542a0cabb08dbc56c406d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C638320840957133285%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%
> 7C&sdata=kxhSaLbYLmFqYkbN%2BXg1lHfwRbRgWrSNy35BMpcMnSk%3D&reser
> ved=0  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |