Message-ID: <CANn89iK226C-pHUJm7HKMyEtMycGC=KCA2M6kw2KJaUj0cCT6w@mail.gmail.com>
Date: Thu, 5 Oct 2023 18:11:56 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, 
	Wolfgang Grandegger <wg@...ndegger.com>, Marc Kleine-Budde <mkl@...gutronix.de>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Chris Snook <chris.snook@...il.com>, Raju Rangoju <rajur@...lsio.com>, 
	Jeroen de Borst <jeroendb@...gle.com>, Praveen Kaligineedi <pkaligineedi@...gle.com>, 
	Shailend Chand <shailend@...gle.com>, Douglas Miller <dougmill@...ux.ibm.com>, 
	Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, 
	Christophe Leroy <christophe.leroy@...roup.eu>, Nick Child <nnac123@...ux.ibm.com>, 
	Haren Myneni <haren@...ux.ibm.com>, Rick Lindsley <ricklind@...ux.ibm.com>, 
	Dany Madden <danymadden@...ibm.com>, Thomas Falcon <tlfalcon@...ux.ibm.com>, 
	Tariq Toukan <tariqt@...dia.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Krzysztof Halasa <khalasa@...p.pl>, Kalle Valo <kvalo@...nel.org>, 
	Jeff Johnson <quic_jjohnson@...cinc.com>, Gregory Greenman <gregory.greenman@...el.com>, 
	Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>, Intel Corporation <linuxwwan@...el.com>, 
	Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>, Liu Haijun <haijun.liu@...iatek.com>, 
	M Chetan Kumar <m.chetan.kumar@...ux.intel.com>, 
	Ricardo Martinez <ricardo.martinez@...ux.intel.com>, Loic Poulain <loic.poulain@...aro.org>, 
	Sergey Ryazanov <ryazanov.s.a@...il.com>, Johannes Berg <johannes@...solutions.net>, 
	Yuanjun Gong <ruc_gongyuanjun@....com>, Simon Horman <horms@...nel.org>, 
	Rob Herring <robh@...nel.org>, Ziwei Xiao <ziweixiao@...gle.com>, 
	Rushil Gupta <rushilg@...gle.com>, Coco Li <lixiaoyan@...gle.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Junfeng Guo <junfeng.guo@...el.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	Wei Fang <wei.fang@....com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Yuri Karpov <YKarpov@...ras.ru>, Zhengchao Shao <shaozhengchao@...wei.com>, 
	Andrew Lunn <andrew@...n.ch>, Zheng Zengkai <zhengzengkai@...wei.com>, Lee Jones <lee@...nel.org>, 
	Maximilian Luz <luzmaximilian@...il.com>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, 
	Dawei Li <set_pte_at@...look.com>, Anjaneyulu <pagadala.yesu.anjaneyulu@...el.com>, 
	Benjamin Berg <benjamin.berg@...el.com>, linux-rdma@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-can@...r.kernel.org, 
	netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, ath10k@...ts.infradead.org, 
	linux-wireless@...r.kernel.org
Subject: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule

On Tue, Oct 3, 2023 at 8:36 PM Christian Marangi <ansuelsmth@...il.com> wrote:
>
> Now that napi_schedule return a bool, we can drop napi_reschedule that
> does the same exact function. The function comes from a very old commit
> bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct
> net_device") and the purpose is actually deprecated in favour of
> different logic.
>
> Convert every user of napi_reschedule to napi_schedule.
>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com> # ath10k
> Acked-by: Nick Child <nnac123@...ux.ibm.com> # ibm
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de> # for can/dev/rx-offload.c

OK, but I suspect some users of napi_reschedule() might not be race-free...

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Powered by blists - more mailing lists