lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3e82593a-f083-8061-5ff3-3e04c70afee6@gmail.com> Date: Thu, 5 Oct 2023 19:43:36 +0100 From: Edward Cree <ecree.xilinx@...il.com> To: Jakub Kicinski <kuba@...nel.org>, edward.cree@....com Cc: linux-net-drivers@....com, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org, habetsm.xilinx@...il.com, sudheer.mogilappagari@...el.com, jdamato@...tly.com, andrew@...n.ch, mw@...ihalf.com, linux@...linux.org.uk, sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com, hkelam@...vell.com, saeedm@...dia.com, leon@...nel.org Subject: Re: [PATCH v4 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice On 05/10/2023 00:10, Jakub Kicinski wrote: > On Wed, 27 Sep 2023 19:13:33 +0100 edward.cree@....com wrote: >> /** >> * struct ethtool_netdev_state - per-netdevice state for ethtool features >> + * @rss_ctx: XArray of custom RSS contexts >> + * @rss_ctx_max_id: maximum (exclusive) supported RSS context ID > > Is this one set by the driver? How would it be set? I was thinking drivers would just assign this directly in their probe routine. > It'd be good if drivers didn't access ethtool state directly. > Makes core easier to refactor if the API is constrained. Would you prefer it as a getter in the ethtool ops? The core would call it every time a new context is being allocated. (In any case, arguably I shouldn't add it in this patch as it's not used until patch #4; I'll fix that in v5 either way.)
Powered by blists - more mailing lists