lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231004162831.0cf1f6a8@kernel.org> Date: Wed, 4 Oct 2023 16:28:31 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Robert Marko <robimarko@...il.com> Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Christian Marangi <ansuelsmth@...il.com>, Luis Chamberlain <mcgrof@...nel.org>, devicetree@...r.kernel.org Subject: Re: [RFC PATCH net-next] net: phy: aquantia: add firmware load support On Sat, 30 Sep 2023 12:39:44 +0200 Robert Marko wrote: > + ret = of_property_read_string(dev->of_node, "firmware-name", > + &fw_name); Perhaps a well established weirdness of the embedded world but why read the fw name from OF?! You can identify what PHY it is and decide the file name based on that. And also put that fw name in MODULE_FIRMWARE() so that initramfs can be built with appropriate file in place :S > + ret = request_firmware(&fw, fw_name, dev);
Powered by blists - more mailing lists