netdev - RE: [PATCH net 1/2] ravb: Fix dma_free_coherent() of desc_bat timing in ravb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 5 Oct 2023 00:26:59 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Sergey Shtylyov <s.shtylyov@....ru>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net 1/2] ravb: Fix dma_free_coherent() of desc_bat timing
 in ravb_remove()

Hello Sergey,

> From: Sergey Shtylyov, Sent: Thursday, October 5, 2023 3:47 AM
> Subject: Re: [PATCH net 1/2] ravb: Fix dma_free_coherent() of desc_bat timing in ravb_remove()

Thank you for your suggestion in other thread. I'll fix the subject.

> On 10/4/23 12:12 PM, Yoshihiro Shimoda wrote:
> 
> > The dma_free_coherent() in ravb_remove() should be called after
> 
>    How about:
> 
> In ravb_remove(), dma_free_coherent() should be called after unregister_netdev().

I got it. I'll fix this.

> > unregister_netdev(). Otherwise, this controller is possible to use
> > the freed buffer.
> >
> > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

Thank you for your review!

Best regards,
Yoshihiro Shimoda

> [...]
> 
> MBR, Sergey