netdev - Re: [PATCH v2 net 1/2] tcp: fix quick-ack counting to count actual ACKs of new data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 04 Oct 2023 22:40:25 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Neal Cardwell <ncardwell.sw@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH v2 net 1/2] tcp: fix quick-ack counting to count actual ACKs
 of new data

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sun,  1 Oct 2023 11:12:38 -0400 you wrote:
> From: Neal Cardwell <ncardwell@...gle.com>
> 
> This commit fixes quick-ack counting so that it only considers that a
> quick-ack has been provided if we are sending an ACK that newly
> acknowledges data.
> 
> The code was erroneously using the number of data segments in outgoing
> skbs when deciding how many quick-ack credits to remove. This logic
> does not make sense, and could cause poor performance in
> request-response workloads, like RPC traffic, where requests or
> responses can be multi-segment skbs.
> 
> [...]

Here is the summary with links:
  - [v2,net,1/2] tcp: fix quick-ack counting to count actual ACKs of new data
    https://git.kernel.org/netdev/net/c/059217c18be6
  - [v2,net,2/2] tcp: fix delayed ACKs for MSS boundary condition
    https://git.kernel.org/netdev/net/c/4720852ed9af

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html