netdev - Re: [PATCHv2 next 1/3] ptp: add ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF2d9jh46s=ai1Ykgk3Lsg8Nb6qRNY6bWPV3fVCTC_S95csyag@mail.gmail.com>
Date: Thu, 5 Oct 2023 16:23:27 -0700
From: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
To: Richard Cochran <richardcochran@...il.com>
Cc: Netdev <netdev@...r.kernel.org>, Linux <linux-kernel@...r.kernel.org>, 
	David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Jonathan Corbet <corbet@....net>, John Stultz <jstultz@...gle.com>, Don Hatchett <hatch@...gle.com>, 
	Yuliang Li <yuliangli@...gle.com>, Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCHv2 next 1/3] ptp: add ptp_gettimex64any() support

On Tue, Oct 3, 2023 at 9:38 PM Richard Cochran <richardcochran@...il.com> wrote:
>
> On Mon, Oct 02, 2023 at 09:17:01PM -0700, Mahesh Bandewar wrote:
> > add support for TS sandwich of the user preferred timebase. The options
> > supported are PTP_TS_REAL (CLOCK_REALTIME), PTP_TS_MONO (CLOCK_MONOTONIC),
> > and PTP_TS_RAW (CLOCK_MONOTONIC_RAW)
> >
> > Option of PTP_TS_REAL is equivalent of using ptp_gettimex64().
>
> This change log is horrible.
>
> Please write a proper explanation, and be sure to cover the following
> three points.
>
> 1. context
> 2. problem
> 3. solution
>
> Every change log must have those three items.
>
> In addition, this series needs a cover letter that clearly justifies
> the need for this change.
>
Fair point and the series does have a cover letter  which you can
access it at https://lore.kernel.org/lkml/20231003041657.1745487-1-maheshb@google.com/
Probably it's fault of my mailer-script which finds the reviewers for
individual patches by running scripts/get_maintainer.pl but then
coverletter is just sent to the mailing-list


> Thanks,
> Richard
>