netdev - Re: [PATCH] xen-netback: use default TX queue size for vifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 6 Oct 2023 14:15:38 +0100
From: Ross Lagerwall <ross.lagerwall@...rix.com>
To: Roger Pau Monne <roger.pau@...rix.com>
Cc: linux-kernel@...r.kernel.org, Wei Liu <wei.liu@...nel.org>, 
	Paul Durrant <paul@....org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Ian Campbell <Ian.Campbell@...rix.com>, Ben Hutchings <bhutchings@...arflare.com>, 
	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org
Subject: Re: [PATCH] xen-netback: use default TX queue size for vifs

On Thu, Oct 5, 2023 at 3:08 PM Roger Pau Monne <roger.pau@...rix.com> wrote:
>
> Do not set netback interfaces (vifs) default TX queue size to the ring size.
> The TX queue size is not related to the ring size, and using the ring size (32)
> as the queue size can lead to packet drops.  Note the TX side of the vif
> interface in the netback domain is the one receiving packets to be injected
> to the guest.
>
> Do not explicitly set the TX queue length to any value when creating the
> interface, and instead use the system default.  Note that the queue length can
> also be adjusted at runtime.
>
> Fixes: f942dc2552b8 ('xen network backend driver')
> Signed-off-by: Roger Pau Monné <roger.pau@...rix.com>
> ---

Reviewed-by: Ross Lagerwall <ross.lagerwall@...rix.com>