netdev - Re: [PATCH net] net/smc: Fix dependency of SMC on ISM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZSAeL1aLpkXVweg6@kernel.org>
Date: Fri, 6 Oct 2023 16:48:15 +0200
From: Simon Horman <horms@...nel.org>
To: Gerd Bayer <gbayer@...ux.ibm.com>
Cc: rdunlap@...radead.org, wenjia@...ux.ibm.com,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	netdev@...r.kernel.org, raspl@...ux.ibm.com, sfr@...b.auug.org.au,
	alibuda@...ux.alibaba.com, wintera@...ux.ibm.com,
	guwen@...ux.alibaba.com, tonylu@...ux.alibaba.com,
	jaka@...ux.ibm.com
Subject: Re: [PATCH net] net/smc: Fix dependency of SMC on ISM

On Fri, Oct 06, 2023 at 02:58:47PM +0200, Gerd Bayer wrote:
> When the SMC protocol is built into the kernel proper while ISM is
> configured to be built as module, linking the kernel fails due to
> unresolved dependencies out of net/smc/smc_ism.o to
> ism_get_smcd_ops, ism_register_client, and ism_unregister_client
> as reported via the linux-next test automation (see link).
> This however is a bug introduced a while ago.
> 
> Correct the dependency list in ISM's and SMC's Kconfig to reflect the
> dependencies that are actually inverted. With this you cannot build a
> kernel with CONFIG_SMC=y and CONFIG_ISM=m. Either ISM needs to be 'y',
> too - or a 'n'. That way, SMC can still be configured on non-s390
> architectures that do not have (nor need) an ISM driver.
> 
> Fixes: 89e7d2ba61b7 ("net/ism: Add new API for client registration")
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Closes: https://lore.kernel.org/linux-next/d53b5b50-d894-4df8-8969-fd39e63440ae@infradead.org/
> Co-developed-by: Wenjia Zhang <wenjia@...ux.ibm.com>
> Signed-off-by: Wenjia Zhang <wenjia@...ux.ibm.com>
> Signed-off-by: Gerd Bayer <gbayer@...ux.ibm.com>

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested