lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <MN0PR12MB5953CC0DAA4E8BA1C3B9CC76B7C9A@MN0PR12MB5953.namprd12.prod.outlook.com> Date: Fri, 6 Oct 2023 18:24:17 +0000 From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com> To: Jakub Kicinski <kuba@...nel.org> CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, "Simek, Michal" <michal.simek@....com>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "f.fainelli@...il.com" <f.fainelli@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "git (AMD-Xilinx)" <git@....com>, Sarath Babu Naidu Gaddam <sarath.babu.naidu.gaddam@....com> Subject: RE: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for dmaengine support > -----Original Message----- > From: Jakub Kicinski <kuba@...nel.org> > Sent: Thursday, October 5, 2023 2:11 AM > To: Pandey, Radhey Shyam <radhey.shyam.pandey@....com> > Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com; > robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org; > conor+dt@...nel.org; Simek, Michal <michal.simek@....com>; > linux@...linux.org.uk; f.fainelli@...il.com; netdev@...r.kernel.org; > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm- > kernel@...ts.infradead.org; git (AMD-Xilinx) <git@....com>; Sarath Babu > Naidu Gaddam <sarath.babu.naidu.gaddam@....com> > Subject: Re: [PATCH net-next v7 2/3] net: axienet: Preparatory changes for > dmaengine support > > On Thu, 28 Sep 2023 01:02:30 +0530 Radhey Shyam Pandey wrote: > > */ > > -static int axienet_open(struct net_device *ndev) > > + > > nit: spurious new line > > > +static inline int axienet_init_legacy_dma(struct net_device *ndev) > > nit: no need for the inline, it has one caller and isn't on the fast path Thanks, will fix both in next version.
Powered by blists - more mailing lists