netdev - Re: [RFC] docs: netdev: encourage reviewers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 6 Oct 2023 11:57:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, jesse.brandeburg@...el.com, sd@...asysnail.net,
 horms@...ge.net.au
Subject: Re: [RFC] docs: netdev: encourage reviewers

On Fri, 6 Oct 2023 20:41:19 +0200 Andrew Lunn wrote:
> We already have:
> 
> https://docs.kernel.org/process/7.AdvancedTopics.html#reviewing-patches
> 
> which has some of the same concepts. I don't think anything in the
> proposed new text is specific to netdev, unlike most of the rest of
> maintainer-netdev.rst which does reference netdev specific rules or
> concepts.
> 
> So i wounder if this even belongs in netdev? Do we actually want to
> extend the current text in "A guide to the Kernel Development
> Process", and maintainer-netdev.rst say something like:
> 
>     Reviewing other people's patches on the list is highly encouraged,
>     regardless of the level of expertise.
> 
> and cross reference to the text in section 7.2?

:) If I can't get it past you there's no chance I'll get it past docs@

Let me move some of the staff into general docs and add a reference.
The questions which came up were about use of tags and how maintainers
approach the reviews from less experienced devs, which I think is
subsystem-specific?