netdev - Re: [PATCH bpf-next v2] net: Add a warning if NAPI cb missed xdp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231006123139.5203444e@kernel.org>
Date: Fri, 6 Oct 2023 12:31:39 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, "David S. Miller"
 <davem@...emloft.net>, Björn Töpel <bjorn@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Eric Dumazet <edumazet@...gle.com>,
 Hao Luo <haoluo@...gle.com>, Jesper Dangaard Brouer <hawk@...nel.org>, Jiri
 Olsa <jolsa@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>, KP Singh <kpsingh@...nel.org>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Magnus Karlsson
 <magnus.karlsson@...el.com>, Martin KaFai Lau <martin.lau@...ux.dev>, Paolo
 Abeni <pabeni@...hat.com>, Song Liu <song@...nel.org>, Stanislav Fomichev
 <sdf@...gle.com>, Thomas Gleixner <tglx@...utronix.de>, Yonghong Song
 <yonghong.song@...ux.dev>
Subject: Re: [PATCH bpf-next v2] net: Add a warning if NAPI cb missed
 xdp_do_flush().

On Fri, 6 Oct 2023 17:49:33 +0200 Sebastian Andrzej Siewior wrote:
>   - Moved xdp_do_check_flushed() to net/core/dev.h.
>   - Stripped __ from function names.
>   - Removed empty lines within an ifdef block.
>   - xdp_do_check_flushed() is now behind CONFIG_DEBUG_NET &&
>     CONFIG_BPF_SYSCALL. dev_check_flush and cpu_map_check_flush are now
>     only behind CONFIG_DEBUG_NET. They have no empty inline function for
>     the !CONFIG_DEBUG_NET case since they are only called in
>     CONFIG_DEBUG_NET case.

Other than the minor nit from the build bot - LGTM now thanks!

Acked-by: Jakub Kicinski <kuba@...nel.org>