netdev - Re: [PATCH net-next 3/3] net: expand skb_segment unit test with frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 7 Oct 2023 00:14:08 +0200
From: Florian Westphal <fw@...len.de>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com, alexander.duyck@...il.com,
	fw@...len.de, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 3/3] net: expand skb_segment unit test with
 frag_list coverage

Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote:
> +	/* TODO: this should also work with SG,
> +	 * rather than hit BUG_ON(i >= nfrags)
> +	 */
> +	if (tcase->id == GSO_TEST_FRAG_LIST_NON_UNIFORM)
> +		features &= ~NETIF_F_SG;

Out of curiosity, this can't be hit outside of this test
because GRO is only source and won't generate skbs that
would trigger this, correct?