netdev - RE: [Intel-wired-lan] [PATCH iwl-net v1] docs: update info about representor identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 6 Oct 2023 21:44:06 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Polchlopek, Mateusz" <mateusz.polchlopek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v1] docs: update info about
 representor identification



> -----Original Message-----
> From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> Sent: Friday, October 6, 2023 2:14 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Polchlopek, Mateusz
> <mateusz.polchlopek@...el.com>; Drewek, Wojciech
> <wojciech.drewek@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] docs: update info about representor
> identification
> 
> Update the "How are representors identified?" documentation
> subchapter. For newer kernels driver developers should use
> SET_NETDEV_DEVLINK_PORT instead of ndo_get_devlink_port()
> callback.
> 
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---

Since this doesn't change an Intel driver, I think this should just be sent directly targeting net tree without needing to go through Intel Wired LAN.

Thanks,
Jake

>  Documentation/networking/representors.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/representors.rst
> b/Documentation/networking/representors.rst
> index ee1f5cd54496..2d6b7b493fa6 100644
> --- a/Documentation/networking/representors.rst
> +++ b/Documentation/networking/representors.rst
> @@ -162,9 +162,9 @@ How are representors identified?
>  The representor netdevice should *not* directly refer to a PCIe device (e.g.
>  through ``net_dev->dev.parent`` / ``SET_NETDEV_DEV()``), either of the
>  representee or of the switchdev function.
> -Instead, it should implement the ``ndo_get_devlink_port()`` netdevice op, which
> -the kernel uses to provide the ``phys_switch_id`` and ``phys_port_name`` sysfs
> -nodes.  (Some legacy drivers implement ``ndo_get_port_parent_id()`` and
> +Instead, driver developers should use ``SET_NETDEV_DEVLINK_PORT`` macro to
> +assign devlink port instance to a netdevice before it registers the netdevice.
> +(Some legacy drivers implement ``ndo_get_port_parent_id()`` and
>  ``ndo_get_phys_port_name()`` directly, but this is deprecated.)  See
>  :ref:`Documentation/networking/devlink/devlink-port.rst <devlink_port>` for the
>  details of this API.
> --
> 2.38.1
>