netdev - RE: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool frag allocation failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <MWHPR1801MB1918374240CCD63E6F4B8DC4D3C9A@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date: Fri, 6 Oct 2023 02:55:38 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com"
	<pabeni@...hat.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "alexander.duyck@...il.com" <alexander.duyck@...il.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "linyunsheng@...wei.com" <linyunsheng@...wei.com>,
        "bigeasy@...utronix.de"
	<bigeasy@...utronix.de>
Subject: RE: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool frag
 allocation failure.

> From: Jakub Kicinski <kuba@...nel.org>
> Subject: [EXT] Re: [PATCH net v1] octeontx2-pf: Fix page pool frag allocation
> failure.
> > +	sz = PAGE_ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size),
> OTX2_ALIGN));
> > +	pp_params.order = get_order(sz);
> 
> Surely get_order() rounds up by itself otherwise all callers would have to do
> the PAGE_ALIGN()...
ACK.