lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231006060631.GC11420@breakpoint.cc> Date: Fri, 6 Oct 2023 08:06:31 +0200 From: Florian Westphal <fw@...len.de> To: Henrik Lindström <lindstrom515@...il.com> Cc: Florian Westphal <fw@...len.de>, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: macvtap performs IP defragmentation, causing MTU problems for virtual machines Henrik Lindström <lindstrom515@...il.com> wrote: > On onsdag 4 oktober 2023 10:00:37 CEST Florian Westphal wrote: > > Can you submit this formally, with proper changelog and Signed-off-by? > > See scripts/checkpatch.pl in the kernel tree. > Sure, i can give it a shot. How do i properly credit you if i submit your > patch with some small changes of my own? You can use: "Suggested-by:" tag here. > > You could also mention in changelog that this is ipv4 only because > > ipv6 already considers the interface index during reassembly. > Interesting. I've been trying to understand the code and it seems like > ipv6 does defragmentation per-interface, while ipv4 does it "per-vrf" > (correct me if i'm wrong). Is there any reason for this difference? Only for linklocal and multicasts. Added in 264640fc2c5f4f913db5c73fa3eb1ead2c45e9d7 . Even mentions macvlan in the changelog. > The idea being that bcast/mcast packets are always defragmented > per-interface, and unicast packets always "per-vrf". LGTM, but please CC dsahern@...nel.org once you submit the patch.
Powered by blists - more mailing lists