netdev - Re: [PATCH v2 1/3] rust: core abstractions for network PHY drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 08 Oct 2023 18:02:57 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: tmgross@...ch.edu
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, andrew@...n.ch,
 miguel.ojeda.sandonis@...il.com, greg@...ah.com
Subject: Re: [PATCH v2 1/3] rust: core abstractions for network PHY drivers

On Sun, 8 Oct 2023 04:54:52 -0400
Trevor Gross <tmgross@...ch.edu> wrote:

> On Sun, Oct 8, 2023 at 3:49 AM FUJITA Tomonori
> <fujita.tomonori@...il.com> wrote:
>> I realized that we don't need `name`. The name of struct doesn't
>> matter so I use `Module`. I tried to use `name` for the name of
>> device_table however the variable name of the table isn't embeded into
>> the module binary so it doesn't matter.
>>
>> FYI, I use paste! but got the following error:
>>
>> = help: message: `"__mod_mdio__\"rust_asix_phy\"_device_table"` is not a valid identifier
>> = note: this error originates in the macro `$crate::module_phy_driver` which comes from the expansion of the
>>   macro `kernel::module_phy_driver` (in Nightly builds, run with -Z macro-backtrace for more info)
> 
> Too bad, this seems to be a limitation of our paste macro compared to
> the published one. What you have with `Module` seems fine so I think
> you don't need it?

Yeah, now I don't use paste! in PHY bindings.