netdev - Re: [PATCH RFC v6 net-next 13/17] p4tc: add table entry create, update, get, delete, flush and dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a57b639c-dd5c-4e16-9943-2c0aec724c5d@lunn.ch>
Date: Sun, 8 Oct 2023 18:53:05 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Vlad Buslov <vladbu@...dia.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, netdev@...r.kernel.org,
	deb.chatterjee@...el.com, anjali.singhai@...el.com,
	namrata.limaye@...el.com, tom@...anda.io, mleitner@...hat.com,
	Mahesh.Shirshyad@....com, tomasz.osinski@...el.com,
	jiri@...nulli.us, xiyou.wangcong@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, kernel@...atatu.com, khalidm@...dia.com,
	toke@...hat.com, mattyk@...dia.com
Subject: Re: [PATCH RFC v6 net-next 13/17] p4tc: add table entry create,
 update, get, delete, flush and dump

> > +/* Invoked from both control and data path  */
> > +static int __p4tc_table_entry_update(struct p4tc_pipeline *pipeline,
> > +				     struct p4tc_table *table,
> > +				     struct p4tc_table_entry *entry,
> > +				     struct p4tc_table_entry_mask *mask,
> > +				     u16 whodunnit, bool from_control)
> > +__must_hold(RCU)
> > +{
> > +	struct p4tc_table_entry_mask *mask_found = NULL;
> > +	struct p4tc_table_entry_work *entry_work;
> > +	struct p4tc_table_entry_value *value_old;
> > +	struct p4tc_table_entry_value *value;
> > +	struct p4tc_table_entry *entry_old;
> > +	struct p4tc_table_entry_tm *tm_old;
> > +	struct p4tc_table_entry_tm *tm;
> > +	int ret;
> > +
> > +	value = p4tc_table_entry_value(entry);
> > +	/* We set it to zero on create an update to avoid having entry
> > +	 * deletion in parallel before we report to user space.
> > +	 */
> > +	refcount_set(&value->entries_ref, 0);
> 
> TBH I already commented on one of the previous versions of this series
> that it is very hard to understand and review tons of different atomic
> reference counters, especially when they are modified with functions
> like refcount_dec_not_one() or unconditional set like in this place.

Hi Vlad

Please always trim replies to just the relevant text. This is a 3000
line patch, which i think you made one comment in, but maybe i missed
others will paging down again, again and again....

       Andrew