netdev - Re: [PATCH net v2] docs: fix info about representor identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84bae196-8e32-4c9d-96c0-c3bcc8d50493@intel.com>
Date: Mon, 9 Oct 2023 13:33:44 +0200
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: <netdev@...r.kernel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <jacob.e.keller@...el.com>, Wojciech Drewek
	<wojciech.drewek@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net v2] docs: fix info about representor identification

On 10/9/2023 1:15 PM, Mateusz Polchlopek wrote:
> Update the "How are representors identified?" documentation
> subchapter. For newer kernels driver developers should use
> SET_NETDEV_DEVLINK_PORT instead of ndo_get_devlink_port()
> callback.
> 
> --
> v1:
> - targeting -net, without IWL
> https://lore.kernel.org/netdev/20231006091412.92156-1-mateusz.polchlopek@intel.com/
> ---
>

There is a typo (two hyphens instead three), so because of that mistake 
tomorrow I will send the v3 patch.

> Fixes: 7712b3e966ea ("Merge branch 'net-fix-netdev-to-devlink_port-linkage-and-expose-to-user'")
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
>   Documentation/networking/representors.rst | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/representors.rst b/Documentation/networking/representors.rst
> index ee1f5cd54496..2d6b7b493fa6 100644
> --- a/Documentation/networking/representors.rst
> +++ b/Documentation/networking/representors.rst
> @@ -162,9 +162,9 @@ How are representors identified?
>   The representor netdevice should *not* directly refer to a PCIe device (e.g.
>   through ``net_dev->dev.parent`` / ``SET_NETDEV_DEV()``), either of the
>   representee or of the switchdev function.
> -Instead, it should implement the ``ndo_get_devlink_port()`` netdevice op, which
> -the kernel uses to provide the ``phys_switch_id`` and ``phys_port_name`` sysfs
> -nodes.  (Some legacy drivers implement ``ndo_get_port_parent_id()`` and
> +Instead, driver developers should use ``SET_NETDEV_DEVLINK_PORT`` macro to
> +assign devlink port instance to a netdevice before it registers the netdevice.
> +(Some legacy drivers implement ``ndo_get_port_parent_id()`` and
>   ``ndo_get_phys_port_name()`` directly, but this is deprecated.)  See
>   :ref:`Documentation/networking/devlink/devlink-port.rst <devlink_port>` for the
>   details of this API.