netdev - Re: [PATCH net-next v5 1/6] posix-clock: introduce posix_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 8 Oct 2023 19:04:02 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Xabier Marquiegui <reibax@...il.com>
Cc: netdev@...r.kernel.org, tglx@...utronix.de, jstultz@...gle.com,
	horms@...nel.org, chrony-dev@...ony.tuxfamily.org,
	mlichvar@...hat.com, ntp-lists@...tcorallo.com,
	vinicius.gomes@...el.com, davem@...emloft.net,
	rrameshbabu@...dia.com, shuah@...nel.org
Subject: Re: [PATCH net-next v5 1/6] posix-clock: introduce
 posix_clock_context concept

On Mon, Oct 09, 2023 at 12:49:16AM +0200, Xabier Marquiegui wrote:

> -int ptp_open(struct posix_clock *pc, fmode_t fmode)
> +int ptp_open(struct posix_clock_context *pccontext, fmode_t fmode)
>  {
>  	return 0;
>  }

You are changing the functional interface, as needed, but I wonder
whether drivers/ptp/ptp_chardev.c is the only driver that implements
open/read/ioctl.

Did you audit the callers of posix_clock_register(), or maybe do a
`make allyesconfig` ?

Thanks,
Richard