netdev - Re: [REGRESSION] Userland interface breaks due to hard HFSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4220ECCB-4B99-43AD-BE6B-36AE86B72871@flyingcircus.io>
Date: Mon, 9 Oct 2023 15:15:44 +0200
From: Christian Theune <ct@...ingcircus.io>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Linux regressions mailing list <regressions@...ts.linux.dev>,
 stable@...r.kernel.org,
 netdev@...r.kernel.org,
 davem@...emloft.net,
 edumazet@...gle.com,
 kuba@...nel.org,
 pabeni@...hat.com
Subject: Re: [REGRESSION] Userland interface breaks due to hard HFSC_FSC
 requirement

Hi,

> On 6. Oct 2023, at 16:13, Bagas Sanjaya <bagasdotme@...il.com> wrote:
>> 
>>> You need to have testing system, unfortunately. It should mimic your
>>> production setup as much as possible. Your organization may have one
>>> already, but if not, you have to arrange for it.
>> 
>> I’m able to do that, I just didn’t have one at hand at this very moment and no time to prepare one within a few minutes. I’ll try to reproduce with a 6.6rc in the next days.
>> 
> 
> OK, thanks!

So, I got around running this with 6.6-rc5 today and yes, it’s broken there as well:

Here’s the output from my testing environment:

#### snip
subtest: try hfsc
machine: must succeed: uname -a
(finished: must succeed: uname -a, in 0.02 seconds)
Linux machine 6.6.0-rc5 #1-NixOS SMP PREEMPT_DYNAMIC Tue Jan  1 00:00:00 UTC 1980 x86_64 GNU/Linux

machine: must succeed: modprobe ifb
(finished: must succeed: modprobe ifb, in 0.02 seconds)
machine: must succeed: modprobe act_mirred
machine # [    9.187251] (udev-worker)[851]: ifb0: Could not set Alias=, MACAddress=/MACAddressPolicy=, TransmitQueues=, ReceiveQueues=, TransmitQueueLength=, MTUBytes=, GenericSegmentOffloadMaxBytes= or GenericSegmentOffloadMaxSegments=, ignoring: Operation not supported
machine # [    9.190616] (udev-worker)[851]: Network interface NamePolicy= disabled on kernel command line.
machine # [    9.192605] (udev-worker)[928]: ifb1: Could not set Alias=, MACAddress=/MACAddressPolicy=, TransmitQueues=, ReceiveQueues=, TransmitQueueLength=, MTUBytes=, GenericSegmentOffloadMaxBytes= or GenericSegmentOffloadMaxSegments=, ignoring: Operation not supported
machine # [    9.197607] (udev-worker)[928]: Network interface NamePolicy= disabled on kernel command line.
machine # [    9.292073] Mirror/redirect action on
(finished: must succeed: modprobe act_mirred, in 0.04 seconds)
machine: must succeed: tc qdisc add dev eth0 handle ffff: ingress
(finished: must succeed: tc qdisc add dev eth0 handle ffff: ingress, in 0.05 seconds)
machine: must succeed: ifconfig ifb0 up
machine # [    9.276585] dhcpcd[672]: ifb0: waiting for carrier
machine # [    9.278532] dhcpcd[672]: ifb0: carrier acquired
machine # [    9.287692] dhcpcd[672]: ifb0: IAID df:2e:ad:2b
machine # [    9.288225] dhcpcd[672]: ifb0: adding address fe80::40d2:dfff:fe2e:ad2b
(finished: must succeed: ifconfig ifb0 up, in 0.02 seconds)
machine: must succeed: tc filter add dev eth0 parent ffff: protocol all u32 match u32 0 0 action mirred egress redirect dev ifb0
machine # [    9.396408] u32 classifier
machine # [    9.396613]     Performance counters on
machine # [    9.396895]     input device check on
machine # [    9.397148]     Actions configured
(finished: must succeed: tc filter add dev eth0 parent ffff: protocol all u32 match u32 0 0 action mirred egress redirect dev ifb0, in 0.04 seconds)
machine: must succeed: tc qdisc add dev ifb0 root handle 1: hfsc default 1
machine # [    9.330784] dhcpcd[672]: ifb1: waiting for carrier
machine # [    9.332246] dhcpcd[672]: ifb1: carrier acquired
machine # [    9.343280] dhcpcd[672]: ifb1: IAID ab:f5:e8:5d
machine # [    9.343868] dhcpcd[672]: ifb1: adding address fe80::2c7f:abff:fef5:e85d
(finished: must succeed: tc qdisc add dev ifb0 root handle 1: hfsc default 1, in 0.03 seconds)
machine: must succeed: tc class add dev ifb0 parent 1: classid 1:999 hfsc rt m2 2.5gbit
(finished: must succeed: tc class add dev ifb0 parent 1: classid 1:999 hfsc rt m2 2.5gbit, in 0.01 seconds)
machine: must succeed: tc class add dev ifb0 parent 1:999 classid 1:1 hfsc sc rate 50mbit
machine # Error: Invalid parent - parent class must have FSC.
machine: output:
Test "try hfsc" failed with error: "command `tc class add dev ifb0 parent 1:999 classid 1:1 hfsc sc rate 50mbit` failed (exit code 2)"
cleanup
kill machine (pid 6)
#### snap

Liebe Grüße,
Christian Theune

-- 
Christian Theune · ct@...ingcircus.io · +49 345 219401 0
Flying Circus Internet Operations GmbH · https://flyingcircus.io
Leipziger Str. 70/71 · 06108 Halle (Saale) · Deutschland
HR Stendal HRB 21169 · Geschäftsführer: Christian Theune, Christian Zagrodnick