netdev - [net-next v3 2/5] netdev: make napi_schedule return bool on NAPI successful schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon,  9 Oct 2023 15:37:51 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Jason Gunthorpe <jgg@...pe.ca>,
	Leon Romanovsky <leon@...nel.org>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Chris Snook <chris.snook@...il.com>,
	Raju Rangoju <rajur@...lsio.com>,
	Jeroen de Borst <jeroendb@...gle.com>,
	Praveen Kaligineedi <pkaligineedi@...gle.com>,
	Shailend Chand <shailend@...gle.com>,
	Douglas Miller <dougmill@...ux.ibm.com>,
	Nick Child <nnac123@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Haren Myneni <haren@...ux.ibm.com>,
	Rick Lindsley <ricklind@...ux.ibm.com>,
	Dany Madden <danymadden@...ibm.com>,
	Thomas Falcon <tlfalcon@...ux.ibm.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Krzysztof Halasa <khalasa@...p.pl>,
	Kalle Valo <kvalo@...nel.org>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Gregory Greenman <gregory.greenman@...el.com>,
	Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
	Intel Corporation <linuxwwan@...el.com>,
	Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
	Liu Haijun <haijun.liu@...iatek.com>,
	M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
	Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
	Loic Poulain <loic.poulain@...aro.org>,
	Sergey Ryazanov <ryazanov.s.a@...il.com>,
	Johannes Berg <johannes@...solutions.net>,
	Christian Marangi <ansuelsmth@...il.com>,
	Yuanjun Gong <ruc_gongyuanjun@....com>,
	Alex Elder <elder@...aro.org>,
	Bhupesh Sharma <bhupesh.sharma@...aro.org>,
	Simon Horman <horms@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Bailey Forrest <bcf@...gle.com>,
	Junfeng Guo <junfeng.guo@...el.com>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Ziwei Xiao <ziweixiao@...gle.com>,
	Rushil Gupta <rushilg@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Yuri Karpov <YKarpov@...ras.ru>,
	Andrew Lunn <andrew@...n.ch>,
	Zheng Zengkai <zhengzengkai@...wei.com>,
	Dawei Li <set_pte_at@...look.com>,
	Anjaneyulu <pagadala.yesu.anjaneyulu@...el.com>,
	Benjamin Berg <benjamin.berg@...el.com>,
	linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-can@...r.kernel.org,
	netdev@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org,
	ath10k@...ts.infradead.org,
	linux-wireless@...r.kernel.org
Subject: [net-next v3 2/5] netdev: make napi_schedule return bool on NAPI successful schedule

Change napi_schedule to return a bool on NAPI successful schedule.
This might be useful for some driver to do additional steps after a
NAPI has been scheduled.

Suggested-by: Eric Dumazet <edumazet@...gle.com>
Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
---
Changes v2:
- Add Suggested-by tag
- Add Reviewed-by tag
---
 include/linux/netdevice.h | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 7e520c14eb8c..2bead8e2a14d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -490,11 +490,18 @@ bool napi_schedule_prep(struct napi_struct *n);
  *
  * Schedule NAPI poll routine to be called if it is not already
  * running.
+ * Return true if we schedule a NAPI or false if not.
+ * Refer to napi_schedule_prep() for additional reason on why
+ * a NAPI might not be scheduled.
  */
-static inline void napi_schedule(struct napi_struct *n)
+static inline bool napi_schedule(struct napi_struct *n)
 {
-	if (napi_schedule_prep(n))
+	if (napi_schedule_prep(n)) {
 		__napi_schedule(n);
+		return true;
+	}
+
+	return false;
 }
 
 /**
-- 
2.40.1