lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 9 Oct 2023 13:36:18 -0700
From: Florian Fainelli <>
To: "Russell King (Oracle)" <>,
 Andrew Lunn <>, Heiner Kallweit <>
Cc: "David S. Miller" <>,
 Eric Dumazet <>, Jakub Kicinski <>,, Paolo Abeni <>,
 Vladimir Oltean <>, Linus Walleij <>
Subject: Re: [PATCH net-next 1/3] net: dsa: vsc73xx: add phylink capabilities

On 10/9/23 03:39, Russell King (Oracle) wrote:
> Add phylink capabilities for vsc73xx. Although this switch driver does
> populates the .adjust_link method, dsa_slave_phy_setup() will still be
> used to create phylink instances for the LAN ports, although phylink
> won't be used for shared links.
> There are two different classes of switch - 5+1 and 8 port. The 5+1
> port switches uses port indicies 0-4 for the user interfaces and 6 for
> the CPU port. The 8 port is confusing - some comments in the driver
> imply that port index 7 is used, but the driver actually still uses 6,
> so that is what we go with. Also, there appear to be no DTs in the
> kernel tree that are using the 8 port variety.
> It also looks like port 5 is always skipped.
> The switch supports 10M, 100M and 1G speeds. It is not clear whether
> all these speeds are supported on the CPU interface. It also looks like
> symmetric pause is supported, whether asymmetric pause is as well is
> unclear. However, it looks like the pause configuration is entirely
> static, and doesn't depend on negotiation results.
> So, let's do the best effort we can based on the information found in
> the driver when creating vsc73xx_phylink_get_caps().
> Signed-off-by: Russell King (Oracle) <>

Reviewed-by: Florian Fainelli <>

Powered by blists - more mailing lists