netdev - Re: [PATCH net-next v4] net: qualcomm: rmnet: Add side band flow control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231010075655.2f8fbeb3@kernel.org>
Date: Tue, 10 Oct 2023 07:56:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Subash Abhinov Kasiviswanathan (KS)" <quic_subashab@...cinc.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, <vadim.fedorenko@...ux.dev>, <lkp@...el.com>,
 <horms@...nel.org>, Sean Tranchetti <quic_stranche@...cinc.com>
Subject: Re: [PATCH net-next v4] net: qualcomm: rmnet: Add side band flow
 control support

On Mon, 9 Oct 2023 22:00:40 -0600 Subash Abhinov Kasiviswanathan (KS)
wrote:
> > I don't understand why you need driver specific commands to do this.
> > It should be easily achievable using existing TC qdisc infra.
> > What's the gap?  
> 
> tc doesn't allow userspace to manipulate the flow state (allow / 
> disallow traffic) on a specific queue. As I understand, the traffic 
> dequeued / queued / dropped on a specific queue of existing qdiscs are 
> controlled by the implementation of the qdisc itself.

I'm not sure what you mean. Qdiscs can form hierarchies.
You put mq first and then whatever child qdisc you want for individual
queues.