netdev - Re: [PATCH net 2/2] selftests: fib_tests: Count all trace point invocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 10 Oct 2023 09:21:53 -0600
From: David Ahern <dsahern@...nel.org>
To: Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, dsahern@...il.com, sriram.yagnaraman@....tech,
 oliver.sang@...el.com, mlxsw@...dia.com
Subject: Re: [PATCH net 2/2] selftests: fib_tests: Count all trace point
 invocations

On 10/10/23 7:21 AM, Ido Schimmel wrote:
> The tests rely on the IPv{4,6} FIB trace points being triggered once for
> each forwarded packet. If receive processing is deferred to the
> ksoftirqd task these invocations will not be counted and the tests will
> fail. Fix by specifying the '-a' flag to avoid perf from filtering on
> the mausezahn task.
> 
> Before:
> 
>  # ./fib_tests.sh -t ipv4_mpath_list
> 
>  IPv4 multipath list receive tests
>      TEST: Multipath route hit ratio (.68)                               [FAIL]
> 
>  # ./fib_tests.sh -t ipv6_mpath_list
> 
>  IPv6 multipath list receive tests
>      TEST: Multipath route hit ratio (.27)                               [FAIL]
> 
> After:
> 
>  # ./fib_tests.sh -t ipv4_mpath_list
> 
>  IPv4 multipath list receive tests
>      TEST: Multipath route hit ratio (1.00)                              [ OK ]
> 
>  # ./fib_tests.sh -t ipv6_mpath_list
> 
>  IPv6 multipath list receive tests
>      TEST: Multipath route hit ratio (.99)                               [ OK ]
> 
> Fixes: 8ae9efb859c0 ("selftests: fib_tests: Add multipath list receive tests")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/netdev/202309191658.c00d8b8-oliver.sang@intel.com/
> Tested-by: kernel test robot <oliver.sang@...el.com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/fib_tests.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>