netdev - Re: [PATCH net] net: tcp: fix crashes trying to free half-baked MTU probes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+PTPUwdEgBDrXNyCWvnTxCqqhfj9d=iNzqSAL-JZ7htg@mail.gmail.com>
Date: Tue, 10 Oct 2023 19:44:08 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	dsahern@...nel.org, clm@...com, osandov@...ndov.com
Subject: Re: [PATCH net] net: tcp: fix crashes trying to free half-baked MTU probes

On Tue, Oct 10, 2023 at 7:36 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> tcp_stream_alloc_skb() initializes the skb to use tcp_tsorted_anchor
> which is a union with the destructor. We need to clean that
> TCP-iness up before freeing.
>
> Fixes: 736013292e3c ("tcp: let tcp_mtu_probe() build headless packets")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

SGTM, thanks !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>