netdev - Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 10 Oct 2023 08:19:48 +0200
From: Peter Korsgaard <peter@...sgaard.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Javier Carrasco <javier.carrasco.cruz@...il.com>,  "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Jakub
 Kicinski <kuba@...nel.org>,  Paolo Abeni <pabeni@...hat.com>,
  syzbot+1f53a30781af65d2c955@...kaller.appspotmail.com,
  netdev@...r.kernel.org,  linux-usb@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in
 dm9601_mdio_read

>>>>> "Greg" == Greg KH <gregkh@...uxfoundation.org> writes:

 > On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote:
 >> syzbot has found an uninit-value bug triggered by the dm9601 driver [1].
 >> 
 >> This error happens because the variable res is not updated if the call
 >> to dm_read_shared_word returns an error. In this particular case -EPROTO
 >> was returned and res stayed uninitialized.
 >> 
 >> This can be avoided by checking the return value of dm_read_shared_word
 >> and propagating the error if the read operation failed.
 >> 
 >> [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955
 >> 
 >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
 >> Reported-and-tested-by: syzbot+1f53a30781af65d2c955@...kaller.appspotmail.com
 >> ---
 >> Changes in v2:
 >> - Remove unnecessary 'err == 0' case
 >> - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com
 >> ---
 >> drivers/net/usb/dm9601.c | 7 ++++++-
 >> 1 file changed, 6 insertions(+), 1 deletion(-)

 > What commit id does this fix?

It has been there since the beginning, so:

Fixes: d0374f4f9c35cdfbee0 ("USB: Davicom DM9601 usbnet driver")

Acked-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard