netdev - Re: [PATCH] Remove extra unlock for the mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab48efc3-9f40-4eed-bdb1-4ce04d3c55cf@gmail.com>
Date: Tue, 10 Oct 2023 15:51:13 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Abhinav Singh <singhabhinav9051571833@...il.com>, davem@...emloft.net,
 dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] Remove extra unlock for the mutex

On 10/10/23 15:46, Abhinav Singh wrote:
> There is a double unlock on mutex. This can cause undefined behaviour.

Where is the double unlock of head->lock (which is a spinlock and not a 
mutex, btw)?

> 
> Signed-off-by: Abhinav Singh <singhabhinav9051571833@...il.com>
> ---
>   net/ipv4/inet_connection_sock.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index aeebe8816689..f11fe8c727a4 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -597,7 +597,6 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)
>   	}
>   	if (head2_lock_acquired)
>   		spin_unlock(&head2->lock);
> -	spin_unlock_bh(&head->lock);
>   	return ret;
>   }
>   EXPORT_SYMBOL_GPL(inet_csk_get_port);

-- 
Florian