netdev - Re: [PATCH net-next 1/2] net: dsa: Use conduit and user terms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 11 Oct 2023 16:53:38 +0800
From: kernel test robot <lkp@...el.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>,
	netdev@...r.kernel.org
Cc: linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: dsa: Use conduit and user terms

Hi Florian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Florian-Fainelli/net-dsa-Use-conduit-and-user-terms/20231011-054044
base:   net-next/main
patch link:    https://lore.kernel.org/r/20231010213942.3633407-2-florian.fainelli%40broadcom.com
patch subject: [PATCH net-next 1/2] net: dsa: Use conduit and user terms
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231011/202310111600.FwR1laqR-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231011/202310111600.FwR1laqR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310111600.FwR1laqR-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/mediatek/mtk_ppe_offload.c: In function 'mtk_flow_get_dsa_port':
   drivers/net/ethernet/mediatek/mtk_ppe_offload.c:178:16: error: implicit declaration of function 'dsa_port_to_master'; did you mean 'dsa_port_is_user'? [-Werror=implicit-function-declaration]
     178 |         *dev = dsa_port_to_master(dp);
         |                ^~~~~~~~~~~~~~~~~~
         |                dsa_port_is_user
>> drivers/net/ethernet/mediatek/mtk_ppe_offload.c:178:14: warning: assignment to 'struct net_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     178 |         *dev = dsa_port_to_master(dp);
         |              ^
   cc1: some warnings being treated as errors


vim +178 drivers/net/ethernet/mediatek/mtk_ppe_offload.c

502e84e2382d92 Felix Fietkau   2021-03-24  164  
502e84e2382d92 Felix Fietkau   2021-03-24  165  static int
502e84e2382d92 Felix Fietkau   2021-03-24  166  mtk_flow_get_dsa_port(struct net_device **dev)
502e84e2382d92 Felix Fietkau   2021-03-24  167  {
502e84e2382d92 Felix Fietkau   2021-03-24  168  #if IS_ENABLED(CONFIG_NET_DSA)
502e84e2382d92 Felix Fietkau   2021-03-24  169  	struct dsa_port *dp;
502e84e2382d92 Felix Fietkau   2021-03-24  170  
502e84e2382d92 Felix Fietkau   2021-03-24  171  	dp = dsa_port_from_netdev(*dev);
502e84e2382d92 Felix Fietkau   2021-03-24  172  	if (IS_ERR(dp))
502e84e2382d92 Felix Fietkau   2021-03-24  173  		return -ENODEV;
502e84e2382d92 Felix Fietkau   2021-03-24  174  
502e84e2382d92 Felix Fietkau   2021-03-24  175  	if (dp->cpu_dp->tag_ops->proto != DSA_TAG_PROTO_MTK)
502e84e2382d92 Felix Fietkau   2021-03-24  176  		return -ENODEV;
502e84e2382d92 Felix Fietkau   2021-03-24  177  
8f6a19c0316deb Vladimir Oltean 2022-09-11 @178  	*dev = dsa_port_to_master(dp);
502e84e2382d92 Felix Fietkau   2021-03-24  179  
502e84e2382d92 Felix Fietkau   2021-03-24  180  	return dp->index;
502e84e2382d92 Felix Fietkau   2021-03-24  181  #else
502e84e2382d92 Felix Fietkau   2021-03-24  182  	return -ENODEV;
502e84e2382d92 Felix Fietkau   2021-03-24  183  #endif
502e84e2382d92 Felix Fietkau   2021-03-24  184  }
502e84e2382d92 Felix Fietkau   2021-03-24  185  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki