[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKa-r6sT=WaTFqumYOEzOKWZoUi0KQ8EYpQ753+C5JjjsUb3wA@mail.gmail.com>
Date: Wed, 11 Oct 2023 12:13:04 +0200
From: Davide Caratti <dcaratti@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Matthieu Baerts <matttbe@...nel.org>, mptcp@...ts.linux.dev,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, Mat Martineau <martineau@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 3/6] Documentation: netlink: add a YAML spec for mptcp
hello, Jakub, thanks for looking at this!
On Wed, Oct 11, 2023 at 3:08 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 10 Oct 2023 21:21:44 +0200 Matthieu Baerts wrote:
> > +definitions:
> > + -
> > + type: enum
> > + name: event-type
> > + enum-name: mptcp_event_type
> > + name-prefix: mptcp_event_
>
> I think you can use - instead of _ here.
> For consistency with other families?
right, I will convert the whole spec.
>
> > + entries:
> > + -
> > + name: unspec
> > + value: 0
>
> 90% sure enums still start at 0, only attrs and msgs now default to 1.
Just checked, value:0 is not needed for enums: I will remove it
> > + -
> > + name: announced
> > + value: 6
> > + doc:
> > + token, rem_id, family, daddr4 | daddr6 [, dport]
> > + A new address has been announced by the peer.
> > + -
> > + name: removed
> > + value: 7
>
> Follows 6 so no need for value?
correct, will fix this too
> > + -
> > + name: addr6
> > + type: binary
> > + checks:
> > + min-len: 16
>
> Do you not want the exact length for this?
> If YNL doesn't support something just LMK, we add stuff as needed..
ohh yes, we had NLA_POLICY_EXACT_LEN before but ynl doesn't seem to
support it. I can try to add the support and include another patch at
the beginning of the series, is that ok?
--
davide
Powered by blists - more mailing lists