netdev - RE: [PATCH net 1/2] selftests: fib_tests: Disable RP filter in multipath list receive test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DBBP189MB14332AEB0F28496D40F4456795CCA@DBBP189MB1433.EURP189.PROD.OUTLOOK.COM>
Date: Wed, 11 Oct 2023 12:23:40 +0000
From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
To: David Ahern <dsahern@...nel.org>, Ido Schimmel <idosch@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "dsahern@...il.com"
	<dsahern@...il.com>, "oliver.sang@...el.com" <oliver.sang@...el.com>,
	"mlxsw@...dia.com" <mlxsw@...dia.com>
Subject: RE: [PATCH net 1/2] selftests: fib_tests: Disable RP filter in
 multipath list receive test



> -----Original Message-----
> From: David Ahern <dsahern@...nel.org>
> Sent: Tuesday, 10 October 2023 17:21
> To: Ido Schimmel <idosch@...dia.com>; netdev@...r.kernel.org
> Cc: davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com;
> edumazet@...gle.com; dsahern@...il.com; Sriram Yagnaraman
> <sriram.yagnaraman@....tech>; oliver.sang@...el.com; mlxsw@...dia.com
> Subject: Re: [PATCH net 1/2] selftests: fib_tests: Disable RP filter in multipath
> list receive test
> 
> On 10/10/23 7:21 AM, Ido Schimmel wrote:
> > The test relies on the fib:fib_table_lookup trace point being
> > triggered once for each forwarded packet. If RP filter is not
> > disabled, the trace point will be triggered twice for each packet (for
> > source validation and forwarding), potentially masking actual bugs.
> > Fix by explicitly disabling RP filter.
> >
> > Before:
> >
> >  # ./fib_tests.sh -t ipv4_mpath_list
> >
> >  IPv4 multipath list receive tests
> >      TEST: Multipath route hit ratio (1.99)                              [ OK ]
> >
> > After:
> >
> >  # ./fib_tests.sh -t ipv4_mpath_list
> >
> >  IPv4 multipath list receive tests
> >      TEST: Multipath route hit ratio (.99)                               [ OK ]
> >
> > Fixes: 8ae9efb859c0 ("selftests: fib_tests: Add multipath list receive
> > tests")
> > Reported-by: kernel test robot <oliver.sang@...el.com>
> > Closes:
> > https://lore.kernel.org/netdev/202309191658.c00d8b8-oliver.sang@intel.
> > com/
> > Tested-by: kernel test robot <oliver.sang@...el.com>
> > Signed-off-by: Ido Schimmel <idosch@...dia.com>
> > ---
> >  tools/testing/selftests/net/fib_tests.sh | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>
> 

Thanks a lot for fixing this
Tested-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>