netdev - Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <82527b7f-4509-4a59-a9cf-2df47e6e1a7c@app.fastmail.com>
Date: Wed, 11 Oct 2023 17:57:38 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jiri Pirko" <jiri@...nulli.us>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Jakub Kicinski" <kuba@...nel.org>, Netdev <netdev@...r.kernel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 linux-wireless@...r.kernel.org, "Johannes Berg" <johannes@...solutions.net>,
 linux-wpan@...r.kernel.org,
 "Michael Hennerich" <michael.hennerich@...log.com>,
 "Paolo Abeni" <pabeni@...hat.com>, "Eric Dumazet" <edumazet@...gle.com>,
 "David S . Miller" <davem@...emloft.net>,
 "Rodolfo Zitellini" <rwz@...ro.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

On Wed, Oct 11, 2023, at 17:04, Jiri Pirko wrote:
> Could you provide a cover letter for the set please?

Subject: [PATCH v2 00/10] remove final .ndo_do_ioctl references

The .ndo_do_ioctl() netdev operation used to be how one communicates
with a network driver from userspace, but since my previous cleanup [1],
it is purely internal to the kernel.

Removing the cops appletalk/localtalk driver made me revisit the
missing pieces from that older series, removing all the unused
implementations in wireless drivers as well as the two kernel-internal
callers in the ieee802154 and appletalk stacks.

One ethernet driver was already merged in the meantime that should
have used .ndo_eth_ioctl instead of .ndo_do_ioctl, so fix that as well.
With the complete removal, any future drivers making this mistake
cause build failures that are easier to spot.

[1] https://lore.kernel.org/netdev/20201106221743.3271965-1-arnd@kernel.org/

----
Hope that helps, I had commented on the cops removal about sending
this but of course not everyone here saw that. Let me know if I should
resend the patches together with the cover letter.

    Arnd