netdev - Re: [PATCH bpf-next v10 2/9] bpf: Propagate modified uaddrlen from cgroup sockaddr programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231011173528.41599-1-kuniyu@amazon.com>
Date: Wed, 11 Oct 2023 10:35:28 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <daan.j.demeyer@...il.com>
CC: <bpf@...r.kernel.org>, <kernel-team@...a.com>, <martin.lau@...ux.dev>,
	<netdev@...r.kernel.org>, <kuniyu@...zon.com>
Subject: Re: [PATCH bpf-next v10 2/9] bpf: Propagate modified uaddrlen from cgroup sockaddr programs

From: Daan De Meyer <daan.j.demeyer@...il.com>
Date: Wed, 11 Oct 2023 19:03:11 +0200
[...]
> @@ -1483,11 +1488,18 @@ int __cgroup_bpf_run_filter_sock_addr(struct sock *sk,
>  	if (!ctx.uaddr) {
>  		memset(&unspec, 0, sizeof(unspec));
>  		ctx.uaddr = (struct sockaddr *)&unspec;
> -	}
> +		ctx.uaddrlen = 0;
> +	} else
> +		ctx.uaddrlen = *uaddrlen;
>  
>  	cgrp = sock_cgroup_ptr(&sk->sk_cgrp_data);
> -	return bpf_prog_run_array_cg(&cgrp->bpf, atype, &ctx, bpf_prog_run,
> -				     0, flags);
> +	ret = bpf_prog_run_array_cg(&cgrp->bpf, atype, &ctx, bpf_prog_run,
> +				    0, flags);
> +
> +	if (!ret && uaddrlen)

nit: no need to check uaddrlen here or maybe check ctx.uaddrlen.


> +		*uaddrlen = ctx.uaddrlen;
> +
> +	return ret;
>  }
>  EXPORT_SYMBOL(__cgroup_bpf_run_filter_sock_addr);
>