[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231010181013.67187de2@kernel.org>
Date: Tue, 10 Oct 2023 18:10:13 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Joel Becker <jlbec@...lplan.org>
Cc: Breno Leitao <leitao@...ian.org>, davem@...emloft.net,
pabeni@...hat.com, Eric Dumazet <edumazet@...gle.com>, hch@....de,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org, horms@...nel.org
Subject: Re: [PATCH net-next v3 2/4] netconsole: Initialize configfs_item
for default targets
On Tue, 10 Oct 2023 12:27:34 -0700 Joel Becker wrote:
> > +#define NETCONSOLE_PARAM_TARGET_NAME "cmdline"
>
> Perhaps `NETCONSOLE_PARAM_TARGET_PREFIX` is better. Makes it clear this
> is not the whole name.
FWIW I had the same thought when looking at v2.
Didn't wanna nit-pick but if there's two of us...
--
pw-bot: cr
Powered by blists - more mailing lists