netdev - Re: [PATCH net-next 3/7] ipv4: add new arguments to udp_tunnel_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a237055b-d617-86da-2fed-8193b2a98a22@kernel.org>
Date: Wed, 11 Oct 2023 12:51:08 -0600
From: David Ahern <dsahern@...nel.org>
To: Beniamino Galvani <b.galvani@...il.com>, netdev@...r.kernel.org
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Guillaume Nault <gnault@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 3/7] ipv4: add new arguments to
 udp_tunnel_dst_lookup()

On 10/9/23 2:20 AM, Beniamino Galvani wrote:
> We want to make the function more generic so that it can be used by
> other UDP tunnel implementations such as geneve and vxlan. To do that,
> add the following arguments:
> 
>  - source and destination UDP port;
>  - ifindex of the output interface, needed by vxlan;
>  - the tos, because in some cases it is not taken from struct
>    ip_tunnel_info (for example, when it's inherited from the inner
>    packet);
>  - the dst cache, because not all tunnel types (e.g. vxlan) want to
>    use the one from struct ip_tunnel_info.
> 
> With these parameters, the function no longer needs the full struct
> ip_tunnel_info as argument and we can pass only the relevant part of
> it (struct ip_tunnel_key).
> 
> Suggested-by: Guillaume Nault <gnault@...hat.com>
> Signed-off-by: Beniamino Galvani <b.galvani@...il.com>
> ---
>  drivers/net/bareudp.c      | 11 +++++++----
>  include/net/udp_tunnel.h   |  8 +++++---
>  net/ipv4/udp_tunnel_core.c | 26 +++++++++++++-------------
>  3 files changed, 25 insertions(+), 20 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>