netdev - Re: [PATCH net-next v4 2/5] ice: configure FW logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231010190110.4181ce87@kernel.org>
Date: Tue, 10 Oct 2023 19:01:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paul M Stillwell Jr <paul.m.stillwell.jr@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <netdev@...r.kernel.org>,
 <jacob.e.keller@...el.com>, <vaishnavi.tipireddy@...el.com>,
 <horms@...nel.org>, <leon@...nel.org>, Pucha Himasekhar Reddy
 <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next v4 2/5] ice: configure FW logging

On Tue, 10 Oct 2023 16:26:15 -0700 Paul M Stillwell Jr wrote:
> I'm probably missing something here, but I don't know if this will do 
> what I need or not. What I have is a user passing a module name and a 
> log level and I'm trying to match those strings and create integer 
> values from them so I can configure the FW log for that module. I'm not 
> seeing how the above gets me there...
> 
> I was trying to not use strncmp and instead use the built in kernel 
> string matching functions so that's how I ended up with the code I have

You're supposed to do very simple and targeted matching here.
The cmdline parsing makes the code harder to follow.