netdev - Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231010191542.3688fe24@hermes.local>
Date: Tue, 10 Oct 2023 19:15:42 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: Yuchung Cheng <ycheng@...gle.com>, "linux-hyperv@...r.kernel.org"
 <linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, KY Srinivasan <kys@...rosoft.com>,
 "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "corbet@....net" <corbet@....net>,
 "dsahern@...nel.org" <dsahern@...nel.org>, "ncardwell@...gle.com"
 <ncardwell@...gle.com>, "kuniyu@...zon.com" <kuniyu@...zon.com>,
 "morleyd@...gle.com" <morleyd@...gle.com>, "mfreemon@...udflare.com"
 <mfreemon@...udflare.com>, "mubashirq@...gle.com" <mubashirq@...gle.com>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "weiwan@...gle.com" <weiwan@...gle.com>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

On Tue, 10 Oct 2023 22:59:49 +0000
Haiyang Zhang <haiyangz@...rosoft.com> wrote:

> > > If this an application specific optimization, it should be in a socket option
> > > rather than system wide via sysctl.  
> > Initially I had a similar comment but later decided a sysctl could
> > still be useful if
> > 1) the entire host (e.g. virtual machine) is dedicated to that application
> > 2) that application is difficult to change  
> 
> Yes, the customer actually wants a global setting. But as suggested by Neal,
> I changed it to be per-namespace to match other TCP tunables.

Like congestion control choice, it could be both a sysctl and a socket option.
The reason is that delayed ack is already controlled by socket options.