netdev - RE: [PATCH bpf-next -v4] net: Add a warning if NAPI cb missed xdp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <652627b386bbe_2d55e208d6@john.notmuch>
Date: Tue, 10 Oct 2023 21:42:27 -0700
From: John Fastabend <john.fastabend@...il.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, 
 Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, 
 bpf@...r.kernel.org, 
 "David S. Miller" <davem@...emloft.net>, 
 Björn Töpel <bjorn@...nel.org>, 
 Alexei Starovoitov <ast@...nel.org>, 
 Andrii Nakryiko <andrii@...nel.org>, 
 Daniel Borkmann <daniel@...earbox.net>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Hao Luo <haoluo@...gle.com>, 
 Jesper Dangaard Brouer <hawk@...nel.org>, 
 Jiri Olsa <jolsa@...nel.org>, 
 John Fastabend <john.fastabend@...il.com>, 
 Jonathan Lemon <jonathan.lemon@...il.com>, 
 KP Singh <kpsingh@...nel.org>, 
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>, 
 Magnus Karlsson <magnus.karlsson@...el.com>, 
 Martin KaFai Lau <martin.lau@...ux.dev>, 
 Paolo Abeni <pabeni@...hat.com>, 
 Song Liu <song@...nel.org>, 
 Stanislav Fomichev <sdf@...gle.com>, 
 Thomas Gleixner <tglx@...utronix.de>, 
 Yonghong Song <yonghong.song@...ux.dev>, 
 Toke Høiland-Jørgensen <toke@...hat.com>
Subject: RE: [PATCH bpf-next -v4] net: Add a warning if NAPI cb missed
 xdp_do_flush().

Sebastian Andrzej Siewior wrote:
> A few drivers were missing a xdp_do_flush() invocation after
> XDP_REDIRECT.
> 
> Add three helper functions each for one of the per-CPU lists. Return
> true if the per-CPU list is non-empty and flush the list.
> Add xdp_do_check_flushed() which invokes each helper functions and
> creates a warning if one of the functions had a non-empty list.
> Hide everything behind CONFIG_DEBUG_NET.
> 
> Suggested-by: Jesper Dangaard Brouer <hawk@...nel.org>
> Reviewed-by: Toke Høiland-Jørgensen <toke@...hat.com>
> Acked-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---

LGTM.

Acked-by: John Fastabend <john.fastabend@...il.com>