netdev - Re: [EXT] Re: [net PATCH] octeon_ep: update BQL sent bytes before ringing doorbell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB47342FEB8D57162EE5765E3CC7D3A@PH0PR18MB4734.namprd18.prod.outlook.com>
Date: Thu, 12 Oct 2023 10:00:05 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Haseeb Gani <hgani@...vell.com>
CC: Vimlesh Kumar <vimleshk@...vell.com>,
        "egallen@...hat.com"
	<egallen@...hat.com>,
        "mschmidt@...hat.com" <mschmidt@...hat.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Sathesh B Edara
	<sedara@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Satananda Burla
	<sburla@...vell.com>,
        Abhijit Ayarekar <aayarekar@...vell.com>
Subject: Re: [EXT] Re: [net PATCH] octeon_ep: update BQL sent bytes before
 ringing doorbell


Hi,

If tx completion and start_xmit happen on 2 different CPUs, how do you
ensure that xmit_completion will observe the values written here?

Specifically, don't you need to move netdev_tx_sent_queue() before the
above memory barrier?

>>> Yes, you are correct. I'll update the changeset. Thank you.