netdev - Re: [PATCH net-next v1 4/8] bnxt_en: devlink health: use retained error fmsg API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73314a75-9356-7381-41c6-087997fe9e55@intel.com>
Date: Thu, 12 Oct 2023 13:34:08 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Michael Chan <michael.chan@...adcom.com>
CC: <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next v1 4/8] bnxt_en: devlink health: use retained
 error fmsg API

On 10/10/23 12:43, Przemek Kitszel wrote:
> Drop unneeded error checking.
> 
> devlink_fmsg_*() family of functions is now retaining errors,
> so there is no need to check for them after each call.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-125 (-125)
> ---
>   .../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 59 ++++---------------

Two out of three broadcom recipients bounce for me,
should I add anyone specific for next version?

[...]