lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231012.205737.1152392964209884159.fujita.tomonori@gmail.com> Date: Thu, 12 Oct 2023 20:57:37 +0900 (JST) From: FUJITA Tomonori <fujita.tomonori@...il.com> To: gregkh@...uxfoundation.org Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, miguel.ojeda.sandonis@...il.com, tmgross@...ch.edu Subject: Re: [PATCH net-next v3 3/3] net: phy: add Rust Asix PHY driver On Mon, 9 Oct 2023 12:10:11 +0200 Greg KH <gregkh@...uxfoundation.org> wrote: > On Mon, Oct 09, 2023 at 10:39:12AM +0900, FUJITA Tomonori wrote: >> This is the Rust implementation of drivers/net/phy/ax88796b.c. The >> features are equivalent. You can choose C or Rust versionon kernel >> configuration. >> >> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com> >> --- >> drivers/net/phy/Kconfig | 7 ++ >> drivers/net/phy/Makefile | 6 +- >> drivers/net/phy/ax88796b_rust.rs | 129 +++++++++++++++++++++++++++++++ >> rust/uapi/uapi_helper.h | 2 + >> 4 files changed, 143 insertions(+), 1 deletion(-) >> create mode 100644 drivers/net/phy/ax88796b_rust.rs >> >> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig >> index 421d2b62918f..0317be180ac2 100644 >> --- a/drivers/net/phy/Kconfig >> +++ b/drivers/net/phy/Kconfig >> @@ -107,6 +107,13 @@ config AX88796B_PHY >> Currently supports the Asix Electronics PHY found in the X-Surf 100 >> AX88796B package. >> >> +config AX88796B_RUST_PHY >> + bool "Rust version driver for Asix PHYs" >> + depends on RUST_PHYLIB_BINDINGS && AX88796B_PHY >> + help >> + Uses the Rust version driver for Asix PHYs (ax88796b_rust.ko) >> + instead of the C version. > > This does not properly describe what hardware this driver supports. And I'll add (by copying the description of the C driver). > that's an odd way to describe the module name, but I see none of the > other entries in this file do that either, so maybe the PHY subsystm > doesn't require that? I leave it to Andrew. This is the first driver in Rust so I thought that users had no idea the relationship between the source file name and the module file name.
Powered by blists - more mailing lists