netdev - Re: [PATCH net-next] net: gso_test: fix build with gcc-12 and earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-K2NmgM=kVFWNgJHahkjXnTF7HdfAEneM5vNLqiuUVU0g@mail.gmail.com>
Date: Thu, 12 Oct 2023 08:15:34 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>, 
	Tasmiya Nalatwad <tasmiya@...ux.vnet.ibm.com>
Subject: Re: [PATCH net-next] net: gso_test: fix build with gcc-12 and earlier

On Thu, Oct 12, 2023 at 8:09 AM Florian Westphal <fw@...len.de> wrote:
>
> gcc 12 errors out with:
> net/core/gso_test.c:58:48: error: initializer element is not constant
>    58 |                 .segs = (const unsigned int[]) { gso_size },
>
> This version isn't old (2022), so switch to preprocessor-bsaed constant
> instead of 'static const int'.
>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Reported-by: Tasmiya Nalatwad <tasmiya@...ux.vnet.ibm.com>
> Closes: https://lore.kernel.org/netdev/79fbe35c-4dd1-4f27-acb2-7a60794bc348@linux.vnet.ibm.com/
> Fixes: 1b4fa28a8b07 ("net: parametrize skb_segment unit test to expand coverage")
> Signed-off-by: Florian Westphal <fw@...len.de>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks for the fix, Florian!

Note to self to not only rely on my default compiler.