netdev - Re: [PATCH net-next] net: gso_test: release each segment individually

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-Lu1dodkaE_nLiMSdbeLikZMm3y5-K=7D2_S1M2W5yO_g@mail.gmail.com>
Date: Thu, 12 Oct 2023 08:27:19 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] net: gso_test: release each segment individually

On Thu, Oct 12, 2023 at 8:03 AM Florian Westphal <fw@...len.de> wrote:
>
> consume_skb() doesn't walk the segment list, so segments other than
> the first are leaked.
>
> Move this skb_consume call into the loop.
>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Fixes: b3098d32ed6e ("net: add skb_segment kunit test")
> Signed-off-by: Florian Westphal <fw@...len.de>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>