lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8804726a-cc2d-fcac-093b-8cd34209d662@amd.com> Date: Thu, 12 Oct 2023 22:59:57 +0530 From: Raju Rangoju <Raju.Rangoju@....com> To: kuba@...nel.org, netdev@...r.kernel.org Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, Shyam-sundar.S-k@....com Subject: Re: [PATCH net] amd-xgbe: read STAT1 register twice to get correct value Hi Jakub, Can you please apply this patch? Let me know if it needs to be resent. Thanks, Raju On 9/14/2023 9:49 AM, Raju Rangoju wrote: > Link status is latched low, so read once to clear > and then read again to get current state. > > Fixes: 4f3b20bfbb75 ("amd-xgbe: add support for rx-adaptation") > Signed-off-by: Raju Rangoju <Raju.Rangoju@....com> > Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@....com> > --- > drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > index 6a716337f48b..c83085285e8c 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c > @@ -2930,6 +2930,7 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart) > > /* check again for the link and adaptation status */ > reg = XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); > + reg = XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); > if ((reg & MDIO_STAT1_LSTATUS) && pdata->rx_adapt_done) > return 1; > } else if (reg & MDIO_STAT1_LSTATUS)
Powered by blists - more mailing lists