netdev - Re: [PATCH v2 net] net/smc: fix smc clc failed issue when netdevice not in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 12 Oct 2023 21:26:25 +0200
From: Wenjia Zhang <wenjia@...ux.ibm.com>
To: Albert Huang <huangjie.albert@...edance.com>,
        Karsten Graul <kgraul@...ux.ibm.com>, Jan Karcher <jaka@...ux.ibm.com>,
        Tony Lu <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>
Cc: "D. Wythe" <alibuda@...ux.alibaba.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] net/smc: fix smc clc failed issue when netdevice
 not in init_net



On 11.10.23 09:48, Albert Huang wrote:
> If the netdevice is within a container and communicates externally
> through network technologies such as VxLAN, we won't be able to find
> routing information in the init_net namespace. To address this issue,
> we need to add a struct net parameter to the smc_ib_find_route function.
> This allow us to locate the routing information within the corresponding
> net namespace, ensuring the correct completion of the SMC CLC interaction.
> 
> Fixes: e5c4744cfb59 ("net/smc: add SMC-Rv2 connection establishment")
> Signed-off-by: Albert Huang <huangjie.albert@...edance.com>
> ---
>   net/smc/af_smc.c | 3 ++-
>   net/smc/smc_ib.c | 7 ++++---
>   net/smc/smc_ib.h | 2 +-
>   3 files changed, 7 insertions(+), 5 deletions(-)
> 

looks good to me, thanks!

Reviewed-by: Wenjia Zhang <wenjia@...ux.ibm.com>