lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231011231020.GG55194@ziepe.ca>
Date: Wed, 11 Oct 2023 20:10:20 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Saeed Mahameed <saeed@...nel.org>
Cc: Leon Romanovsky <leon@...nel.org>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Matthew Rosato <mjrosato@...ux.ibm.com>,
	Joerg Roedel <joro@...tes.org>, Robin Murphy <robin.murphy@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shay Drory <shayd@...dia.com>, Moshe Shemesh <moshe@...dia.com>,
	Heiko Carstens <hca@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net/mlx5: fix calling mlx5_cmd_init() before DMA
 mask is set

On Wed, Oct 11, 2023 at 11:45:04AM -0700, Saeed Mahameed wrote:
> > > The above works too. Maybe for consistency within probe_one() it would
> > > then make sense to also rename set_dma_caps() to mlx5_dma_init()?
> > 
> > Sounds great, thanks
> > 
> > BTW, I was informed offlist that Saeed also has fix to this issue,
> > but I don't know if he wants to progress with that fix as it has wrong
> > RCA in commit message and as an outcome of that much complex solution,
> > which is not necessary.
> > 
> > So I would be happy to see your patch with mlx5_dma_init().
> > 
> > Thanks
> > 
> 
> Actually I prefer the internal patch, it moves the dma parts out of
> mlx5_cmd_init() into mlx5_cmd_enable() which happens after dma caps are
> set. since it is using the current mlx5 function structure and breakdown, I
> prefer it over adding new function to the driver.
> 
> I will share the patch, I will let Niklas test it and approve it before
> submission.

Let's hurry please, mlx5 will be broken on S390 in rc1 if this is not
fixed soon.

Jason

Powered by blists - more mailing lists