netdev - Re: [net-next PATCH v4 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e08c82c-d9a4-4d39-a4cc-3cd007e4242f@intel.com>
Date: Wed, 11 Oct 2023 16:28:36 -0700
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v4 01/10] netdev-genl: spec: Extend netdev
 netlink spec in YAML for queue

On 10/10/2023 7:12 PM, Jakub Kicinski wrote:
> On Fri, 06 Oct 2023 02:14:43 -0700 Amritha Nambiar wrote:
>> Add support in netlink spec(netdev.yaml) for queue information.
>> Add code generated from the spec.
>>
>> Note: The "queue-type" attribute currently takes values 0 and 1
>> for rx and tx queue type respectively. I haven't figured out the
>> ynl library changes to support string user input ("rx" and "tx")
>> to enum value conversion in the generated C code.
> 
> Let's leave the maxrate out of this version entirely, please.
> Otherwise looks good.

Okay, will remove maxrate in v5.